Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mute Banner for Profile & Prevent Self-Target & Correctly Expire Early Unmutes #272

Merged
merged 8 commits into from
Oct 24, 2022
Merged

Mute Banner for Profile & Prevent Self-Target & Correctly Expire Early Unmutes #272

merged 8 commits into from
Oct 24, 2022

Conversation

Ayymoss
Copy link
Collaborator

@Ayymoss Ayymoss commented Oct 21, 2022 •
edited
Loading

Add a temp/mute banner to their profile. (Priority lowered so as not to overwrite temp/ban banners)
Let the user know they cannot target themselves.
Displays mute expiration on penalty if unmuted early.
Added condition to prevent expiration unmute spam.

COMMANDS_DENY_SELF_TARGET = You cannot target yourself

WEBFRONT_PROFILE_MUTE_INFO = Temporarily muted for {{reason}} with {{time}} remaining
WEBFRONT_PROFILE_TEMPMUTE_INFO = Permanently muted for {{reason}}

@Ayymoss
Fix self-targeting
98a7474 
Remove creation of penalty on mute expiration
@Ayymoss
Display mute penalties on profile
2649438 
Expire mute penalties on unmute
@Ayymoss
Resolves issues in code review
b54d107 
Added comment in ClientController.cs
Fixed order of operations in MuteManager.cs
Fixed condition in MuteManager.cs
@Ayymoss @RaidMax
Fix self-targeting
fe08463 
Remove creation of penalty on mute expiration
@Ayymoss @RaidMax
Display mute penalties on profile
34da216 
Expire mute penalties on unmute
@Ayymoss @RaidMax
Resolves issues in code review
9778bea 
Added comment in ClientController.cs
Fixed order of operations in MuteManager.cs
Fixed condition in MuteManager.cs
@Ayymoss Ayymoss changed the title Display Mute Banner for Profile & Prevent Self-Target & Correct Expire Mutes Mute Banner for Profile & Prevent Self-Target & Correctly Expire Early Unmutes Oct 23, 2022
@Ayymoss
Changed localisation value to be more generic
a3dbd88 
Fix null reference warning (it should never be null) (34da216)
@Ayymoss Ayymoss requested a review from RaidMax October 23, 2022 21:18
@RaidMax RaidMax merged commit 7180bfe into RaidMax:release/pre Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaidMax RaidMax RaidMax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ayymoss @RaidMax