Split item and effect localizations into separate folder.#20
Open
Menchcruts wants to merge 1 commit intoRaidTheory:mainfrom
Open
Split item and effect localizations into separate folder.#20Menchcruts wants to merge 1 commit intoRaidTheory:mainfrom
Menchcruts wants to merge 1 commit intoRaidTheory:mainfrom
Conversation
Contributor
|
I've thought about this but haven't thought of a good way to approach it yet. Let me take a look at see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found the
items.jsonfile to be too cluttered with all the localizations in-line with normal data.This merge would split the localizations of items and effects into a separate
localizationsfolder, with English being the default language initems.json.Tests have been run to check for missing data.
If this pull request is approved, I can also start work on separating other files.