publish, append and link with nil #1466
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9b5081e.
This reverts commit bda28e0.
This reverts commit fcaa701.
This reverts commit db1b197.
This reverts commit 101540d.
This reverts commit ccc697e.
This reverts commit c8310c8.
This reverts commit 4d1508f.
This reverts commit b599d6a.
This reverts commit b5a4e30.
This reverts commit 83ca36d.
This reverts commit 310bdf8.
Since we have introduced AggregateRoot::Repository it is easy to pass event store as a dependency there. No need to use AggregateRoot::Configuration and default_event_store. Make it explicte which event store is used. Less "magic".
* no sane way to support event type scheme for extract last part * no sane way to normalize every event type to method name
…nt"" This reverts commit 95d9bc9.
This reverts commit 12d7330.
This reverts commit 9ee7904.
mostlyobvious
force-pushed
the
revert-1465-roll-it-back
branch
from
6f44fed to
111ce04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the discussion. This is however API-breaking change, even if part of this was unspecified behaviour. We'll delay this change a bit to next major release.
Reverts #1465
Changelog entry: