Skip to content

Commit

Permalink
src: add TODO for supporting import()
Browse files Browse the repository at this point in the history
Refs: nodejs#48191 (comment)
Signed-off-by: Darshan Sen <raisinten@gmail.com>
  • Loading branch information
RaisinTen committed Jun 8, 2023
1 parent 1ad0ce7 commit 7a19ac1
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/node_sea.cc
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,9 @@ std::optional<std::string> GenerateCodeCache(std::string_view main_path,
FIXED_ONE_BYTE_STRING(isolate, "__dirname"),
};

// TODO(RaisinTen): Using the V8 code cache prevents us from using `import()`
// in the SEA code. Support it.
// Refs: https://github.com/nodejs/node/pull/48191#discussion_r1213271430
Local<Function> fn;
if (!contextify::CompileFunction(
isolate, context, filename, content, &parameters)
Expand Down

0 comments on commit 7a19ac1

Please sign in to comment.