fs: fix busy loop in recursive rm for windows

Fixes: nodejs#34580

lib/internal/fs/rimraf.js

@@ -231,7 +231,7 @@ function _rmdirSync(path, options, originalErr) {
   } catch (err) {
     if (err.code === 'ENOENT')
       return;
-    if (err.code === 'ENOTDIR')
+    if (err.code === 'EACCES' || err.code === 'ENOTDIR')
       throw originalErr;
 
     if (notEmptyErrorCodes.has(err.code)) {

test/parallel/test-recursive-rm-busy-loop-windows.js

@@ -0,0 +1,44 @@
+'use strict';
+require('../common');
+
+// This test ensures that recursive rm throws EACCES instead of
+// going into a busy-loop for this scenario:
+// https://github.com/nodejs/node/issues/34580
+
+const assert = require('assert');
+const fs = require('fs');
+const tmpdir = require('../common/tmpdir');
+const { join } = require('path');
+
+tmpdir.refresh();
+
+function rmdirRecursiveSync() {
+  const root = fs.mkdtempSync(tmpdir.path);
+
+  const middle = join(root, 'middle');
+  fs.mkdirSync(middle);
+  fs.mkdirSync(join(middle, 'leaf')); // Make `middle` non-empty
+  fs.chmodSync(middle, 0);
+
+  // Windows can EPERM on stat, which is called inside rmdirSync.
+  let runTest = false;
+  try {
+    fs.statSync(middle);
+    runTest = true;
+  } catch (err) {
+    assert.strictEqual(err.code, 'EPERM');
+  } finally {
+    try {
+      if (runTest) {
+        assert.throws(() => {
+          fs.rmSync(root, { recursive: true });
+        }, /EACCES/);
+      }
+    } finally {
+      fs.chmodSync(middle, 0o777);
+      fs.rmdirSync(root, { recursive: true });
+    }
+  }
+}
+
+rmdirRecursiveSync();