changes based on the comments

Rajasekhar-Vuppala · Jun 7, 2024 · ec95b21 · ec95b21
1 parent ffe39df
commit ec95b21
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 11 deletions.
diff --git a/metadata-ingestion/src/datahub/ingestion/source/sql/vertica.py b/metadata-ingestion/src/datahub/ingestion/source/sql/vertica.py
@@ -135,16 +135,6 @@ def create(cls, config_dict: Dict, ctx: PipelineContext) -> "VerticaSource":
  def get_workunits_internal(self) -> Iterable[Union[MetadataWorkUnit, SqlWorkUnit]]:
  yield from super().get_workunits_internal()
  sql_config = self.config
- if logger.isEnabledFor(logging.DEBUG):
- # If debug logging is enabled, we also want to echo each SQL query issued.
- sql_config.options.setdefault("echo", True)
-
- # Extra default SQLAlchemy option for better connection pooling and threading.
- # https://docs.sqlalchemy.org/en/14/core/pooling.html#sqlalchemy.pool.QueuePool.params.max_overflow
- if sql_config.is_profiling_enabled():
- sql_config.options.setdefault(
- "max_overflow", sql_config.profiling.max_workers
- )
 
  for inspector in self.get_inspectors():
  profiler = None

diff --git a/metadata-ingestion/tests/integration/vertica/docker-compose.yml b/metadata-ingestion/tests/integration/vertica/docker-compose.yml
@@ -4,6 +4,7 @@ services:
  platform: linux/amd64
  environment:
  APP_DB_USER: "dbadmin"
+ APP_DB_PASSWORD: "abc123"
  container_name: vertica-ce
  image: vertica/vertica-ce:23.4.0-0
  ports:

diff --git a/metadata-ingestion/tests/integration/vertica/vertica_to_file.yml b/metadata-ingestion/tests/integration/vertica/vertica_to_file.yml
@@ -4,7 +4,7 @@ source:
  host_port: 127.0.0.1:5433
  database: Vmart
  username: dbadmin
- password: 
+ password: abc123
  include_tables: true
  include_views: true
  include_projections: true