Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes based on the comments #2

Merged
merged 1 commit into from
Jun 7, 2024
Merged

changes based on the comments #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions metadata-ingestion/src/datahub/ingestion/source/sql/vertica.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,16 +135,6 @@ def create(cls, config_dict: Dict, ctx: PipelineContext) -> "VerticaSource":
def get_workunits_internal(self) -> Iterable[Union[MetadataWorkUnit, SqlWorkUnit]]:
yield from super().get_workunits_internal()
sql_config = self.config
if logger.isEnabledFor(logging.DEBUG):
# If debug logging is enabled, we also want to echo each SQL query issued.
sql_config.options.setdefault("echo", True)

# Extra default SQLAlchemy option for better connection pooling and threading.
# https://docs.sqlalchemy.org/en/14/core/pooling.html#sqlalchemy.pool.QueuePool.params.max_overflow
if sql_config.is_profiling_enabled():
sql_config.options.setdefault(
"max_overflow", sql_config.profiling.max_workers
)

for inspector in self.get_inspectors():
profiler = None
Expand Down
1 change: 1 addition & 0 deletions metadata-ingestion/tests/integration/vertica/docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ services:
platform: linux/amd64
environment:
APP_DB_USER: "dbadmin"
APP_DB_PASSWORD: "abc123"
container_name: vertica-ce
image: vertica/vertica-ce:23.4.0-0
ports:
Expand Down
2 changes: 1 addition & 1 deletion metadata-ingestion/tests/integration/vertica/vertica_to_file.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ source:
host_port: 127.0.0.1:5433
database: Vmart
username: dbadmin
password:
password: abc123
include_tables: true
include_views: true
include_projections: true
Expand Down
Loading