[Sema] Improves diagnostic when passing an argument as property of an…

… optional class instance (swiftlang#57437)
Rajveer100 · Sep 1, 2023 · 3ad2fc6 · 3ad2fc6
1 parent a5607cc
commit 3ad2fc6
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/lib/Sema/CSSimplify.cpp b/lib/Sema/CSSimplify.cpp
@@ -6453,6 +6453,13 @@ bool ConstraintSystem::repairFailures(
                             getConstraintLocator(anchor, path));
     }
 
+    if (!path.empty()) {
+      if (path.back().is<LocatorPathElt::ApplyArgToParam>())
+        conversionsOrFixes.push_back(AllowArgumentMismatch::create(*this, lhs, rhs, getConstraintLocator(anchor, path)));
+      else if (path.back().is<LocatorPathElt::ContextualType>())
+        conversionsOrFixes.push_back(IgnoreContextualType::create(*this, lhs, rhs, getConstraintLocator(anchor, path)));
+    }
+
     // When the solver sets `TMF_MatchingGenericArguments` it means
     // that it's matching generic argument pairs to identify any mismatches
     // as part of larger matching of two generic types. Letting this