Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to document rakudo bugs? #1486

Open
AlexDaniel opened this issue Sep 1, 2017 · 15 comments
Open

How to document rakudo bugs? #1486

AlexDaniel opened this issue Sep 1, 2017 · 15 comments
Assignees
Labels
meta RFCs, general discussion, writing style, repository organization, etc. xt Regarding current or new xt/ tests or the utils/

Comments

@AlexDaniel
Copy link
Member

I know that the first thought may be “let's not”, but hold your horses.

See this discussion: https://irclog.perlgeek.de/perl6/2017-09-01#i_15103501

The current situation is indeed LTA for the user, but linking all rakudobugs in the docs is way too LTA for us. We need some clever solution.

Any ideas? Like maybe some separate resource (“6aniuse”?) with a table of all features and the status in each implementation. Pretty much like https://perl6.org/compilers/features. Then maybe we can link to it automatically from the docs.

@AlexDaniel AlexDaniel added the meta RFCs, general discussion, writing style, repository organization, etc. label Sep 1, 2017
@AlexDaniel
Copy link
Member Author

AlexDaniel commented Sep 1, 2017

While we are discussing this to death, here's the plan: boldly document important bugs. Here's an example of a bug that needs to be mentioned.

There are more than 1500 open tickets, but not all of them deserve a mention in the docs. I am predicting that with ≈20 ticket mentions we can make sure that users see information about serious bugs that can cause a disaster. This works today, but once we have a better system we can always revert these changes.

@JJ
Copy link
Contributor

JJ commented Feb 16, 2018

Why don't you link some bugs that should be mentioned, and we try and document them?

@AlexDaniel
Copy link
Member Author

Well, there's SEVERE tag that may be used for that. See RT and GH. But that tag is not being used consistently (IIRC I'm the only one using it), so there are not many tickets.

@JJ
Copy link
Contributor

JJ commented Feb 16, 2018 via email

@jnthn
Copy link
Contributor

jnthn commented Feb 17, 2018

If bugs are to be mentioned in the docs, and the concern is about knowing to remove the mentions when they are fixed (or include a "fixed from Rakudo YYYY.MM"), perhaps it would be possible to somehow have an "inverse test" associated with each one - that is, a test case that passes so long as the bug is present, and starts to fail when fixed. Or, perhaps less work, some reference to the bug's GitHub issue and a script run regularly that points out when said issues are closed.

@JJ
Copy link
Contributor

JJ commented Feb 17, 2018 via email

@AlexDaniel AlexDaniel added the xt Regarding current or new xt/ tests or the utils/ label Mar 4, 2018
@AlexDaniel
Copy link
Member Author

So basically a way to write a snippet that will eventually fail when you run xtest and the bug is fixed? @coke what do you think?

@coke
Copy link
Collaborator

coke commented Mar 5, 2018

Our current code testing is compile time checks only (wherever possible) - I think having a standard way to refer to the bug status and then check the bug status (rather than running code) is the way to go. We could just say any bug covered this way has to have a github issue, making it easier to do the check.

@JJ
Copy link
Contributor

JJ commented Apr 15, 2018

Hum. I don't see an easy way to do this. Plus we are doing this before documenting any bugs. I would say that when the need arises, just insert a =comment in the documentation saying : please remember to check this and that out. If we add tests for state of bugs anyway, please make that a separate issue (and maybe include the NOTSPECCED and NYI issues). But really, I don't think that's going to be needed at all.

AlexDaniel added a commit that referenced this issue May 31, 2018
Normally implementation-specific things are not documented, but in
this particular case we can prevent a lot of banging against a wall by
mentioning some known issues. In this case the behavior has changed
quite a bit so IMO it's a worthy mention.

See issue #1486 for more info on docs vs implementation-specific notes.
@coke coke self-assigned this Nov 14, 2022
@coke
Copy link
Collaborator

coke commented Nov 14, 2022

@coke
Copy link
Collaborator

coke commented Nov 14, 2022

if someone can please identify at least one rakudo bug that we should document, I'll write the test and then we'll have a way forward for any new ones.

@coke coke added the help wanted We need some help here label Nov 14, 2022
@patrickbkr
Copy link
Member

I think rakudo/rakudo#2380 would be easy to test and is specific.

@coke coke removed their assignment Aug 15, 2023
@coke coke self-assigned this May 14, 2024
@coke coke added this to the 2024-Quarter-2 milestone May 14, 2024
@coke
Copy link
Collaborator

coke commented May 17, 2024

@patrickbkr can you suggest where in the docs we should warn about that bug and maybe some text for it? Then I can focus on checking the bug status in an xt/ test.

@patrickbkr
Copy link
Member

@coke I think the bug I mentioned four years ago is not a good example anymore, because of these four PRs which I plan to get merged soon-ish. I'll have to think a bit if I can come up with a better example issue.

@coke
Copy link
Collaborator

coke commented May 24, 2024

It looks like several links exist already in =comment blocks... but it also looks like =comment blocks are stripped in our process by precompilation and not available when we are examining $=pod.

Once we can see the =comment block, we can examine the L<> to see if the referenced issue is open or closed. If closed, we fail the test for that link, with a note to remove the comment or exposed link.

We could also move the links to issues outside of a =comment block (but this requires some editor-ing)

@coke coke removed the help wanted We need some help here label May 24, 2024
@coke coke modified the milestones: 2024-Quarter-2, 2024-Quarter-3 Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta RFCs, general discussion, writing style, repository organization, etc. xt Regarding current or new xt/ tests or the utils/
Projects
None yet
Development

No branches or pull requests

5 participants