Serialization format 23 for nqp-JS #655
Merged
+5
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nqp-JS is currently a cross-compiler, and so needs to be able to read the serialization output of MoarVM. As of Feb 2020, commit 9709537d90d61529 the MoarVM serialization format was bumped from version 22 to version 23, as it now also serializes closure names.
This broke the nqp-JS build, but it seems that no-one noticed.
This fixes the build at 2020-07 (the current release), but unfortunately additional fixes are needed for changes now made on master. (report coming soon)
With this commit atop
2020-07
I still see these test failures:t/nqp/060-bigint.t
andt/hll/06-sprintf.t
were both also failing in the same way immediately prior to MoarVM commit 9709537d90d61529.t/nqp/100-dispatcher.t
fails new tests added after later by commit aadea88 -- Add nextdispatcherfor/takenextdispatcher ops. Specifically it fails withTrace: NYI: unimplemented QAST::Op nextdispatcherfor
andTrace: NYI: unimplemented QAST::Op takenextdispatcher
t/nqp/114-pod-panic.t
fails as a result ofIt's unclear what the correct fix for that should be - clearly nqp doesn't work totally cleanly as a cross-compiler.