Add a test ensuring a Hash iterator misuse is not exploding #731
Conversation
t/nqp/108-vmhash.t
Outdated
| } | ||
| } | ||
|
|
||
| ok($msg eq "", 'No SEGV on a misused hash iterator'); |
There was a problem hiding this comment.
I'm not seeing $msg being changed? Is that just to create a valid ok test? If that was the intent, you can also say:
pass 'No SEGV on a misused hash iterator'
There was a problem hiding this comment.
Oh, my bad as I did not add $msg = ... bit into CATCH, huh.
Also, given it is not directly an exception, but a SEGV is maybe a better option, let's see...
There was a problem hiding this comment.
There is apparently no pass in nqp, so just corrected the bit.
There was a problem hiding this comment.
Altai-man: It looks like the test actually checks for both no SEGV (by happening at all) and no exception (by leaving $msg unchanged). Might be worth changing the test description to match that.
Altai-man
force-pushed
the
tests-for-iterator-misuse
branch
from
a19e355 to
98f38a4
Compare
|
The test failures seem to be flappers. :( |
Closes rakudo/rakudo#1340 (aims to)
I am really not sure where the nqp integration tests should belong, but this appears like the most fitting place to me, please check those with wisdom.