Skip to content

Commit

Permalink
Auto merge of #99660 - PrestonFrom:issue_99265, r=compiler-errors
Browse files Browse the repository at this point in the history
Generate correct suggestion with named arguments used positionally

Address issue #99265 by checking each positionally used argument
to see if the argument is named and adding a lint to use the name
instead. This way, when named arguments are used positionally in a
different order than their argument order, the suggested lint is
correct.

For example:
```
println!("{b} {}", a=1, b=2);
```
This will now generate the suggestion:
```
println!("{b} {a}", a=1, b=2);
```

Additionally, this check now also correctly replaces or inserts
only where the positional argument is (or would be if implicit).
Also, width and precision are replaced with their argument names
when they exists.

Since the issues were so closely related, this fix for issue #99265
also fixes issue #99266.

Fixes #99265
Fixes #99266
  • Loading branch information
bors committed Jul 29, 2022
2 parents 16f3268 + 3e45c72 commit c46d94c
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit c46d94c

Please sign in to comment.