Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS100 Thermal Runaway Retune/Option to disable #1946

Closed
Tekz42 opened this issue Jul 10, 2024 · 13 comments · Fixed by #2012
Closed

TS100 Thermal Runaway Retune/Option to disable #1946

Tekz42 opened this issue Jul 10, 2024 · 13 comments · Fixed by #2012
Assignees
Labels
Enhancement New feature or additional function. Next Release Items for next release consideration.
Milestone

Comments

@Tekz42
Copy link

Tekz42 commented Jul 10, 2024

Is your feature request related to a problem? Please describe.
TS100 going into thermal runaway constantly while soldering with low voltage power sources i.e. 3s LiPo. This makes soldering in the field a headache as Iron is constantly going into cooldown causing joints to be half soldered.

Describe the solution you'd like
Retune of Thermal Runaway or Option to disable Thermal Runaway.

Describe alternatives you've considered
Buy higher voltage power sources.

Additional context
N/A

@Ralim Ralim added this to the 2.23 milestone Jul 11, 2024
@ia ia added Enhancement New feature or additional function. Next Release Items for next release consideration. labels Jul 11, 2024
@Eheran1
Copy link

Eheran1 commented Aug 20, 2024

I have previously reported this issue with my TS80. If you work on something that takes time to heat up and then stabilizes on some temperature, the TS80 goes into runaway mode. Please add a some test before triggering this mode: Turn down heating a bit (say 50%) and see if the temperature drops. AFAIK this should not be the case with an actual runaway, where the temperature sensing itself is broken? So it would not decrease in that case. But not sure if I understand the mechanics behind a runaway correctly.

@Ralim
Copy link
Owner

Ralim commented Dec 7, 2024

I've had a crack at a different style of detector.
Could you try these builds? https://github.com/Ralim/IronOS/actions/runs/12209178967
@Eheran1 / @Tekz42

@Eheran1
Copy link

Eheran1 commented Dec 7, 2024

Sorry, not sure what to do with your link. Really not a Github expert. How should I proceed to test it?

@discip
Copy link
Collaborator

discip commented Dec 7, 2024

@Eheran1
Copy link

Eheran1 commented Dec 10, 2024 via email

@discip
Copy link
Collaborator

discip commented Dec 10, 2024

Were you able to open the link Ralim provided? https://github.com/Ralim/IronOS/actions/runs/12209178967

If so, please proceed as follows:

  1. Open the link,
  2. scroll down to the bottom of the page and
  3. choose the package you need
  4. by clicking on it.

image

@bamdadkhan
Copy link

bamdadkhan commented Dec 12, 2024

hi, although i'm not the OP, i was able to download the artifact after logging in.

i can also confirm that the 'thermal runaway' situation seems to be fixed, at least on my TS80.

thank you < 3

@Eheran1
Copy link

Eheran1 commented Dec 12, 2024

I have no way to test it right now, but could you point me to the function(s) that does the test/finds the runaway? I would like to look at it. Also, I could try to feed it some data that looks like what I remember.

@Ralim
Copy link
Owner

Ralim commented Dec 16, 2024

@Eheran1 You can see the changes here https://github.com/Ralim/IronOS/pull/2012/files

@Eheran1
Copy link

Eheran1 commented Dec 16, 2024

Ah thank you. So the essence is:

  • Always update lowest tip temperature seen
  • Only update highest tip temperature seen when currently heating
  • If we have been heating for longer than "THERMAL_RUNAWAY_TIME_SEC" (now 20, previous 45)
  • And if the highest tip temperature seen is larger than the minimum (when is this not the case?)
  • Then if the dT is smaller than "THERMAL_RUNAWAY_TEMP_C" (now set to 3 instead of previous 10 for various devices) we get the thermal runaway.

The core change seems to be the different threshold of less than 3 °C of change needed to signal a runaway condition. How much does the temperature fluctuate during a runaway condition? This would still trigger if the temperature is not changing much, like due to high thermal mass compared to heating power. I would prefer an additional test as a "second stage" after this initial test. It should turn the heater off (or lower) for a second or so (depending on the dynamics of the system, I assume 1 s is enough for a significant cool down) to check if that does anything. If it does cause a substantial cooling, then do not trigger the test again for something like 10 minutes. While the short cooling is perhaps still annoying: It is only once, very short, and automatically stops without looking at the display and/or pressing something.

Relevant code:

  if (currentTipTempInC < tiptempMin) {
    tiptempMin = currentTipTempInC;
  }

  if (thisCycleIsHeating && currentTipTempInC > tipTempMax) {
    tipTempMax = currentTipTempInC;
  }
  
    if ((xTaskGetTickCount() - heatCycleStart) > (THERMAL_RUNAWAY_TIME_SEC * TICKS_SECOND)) {
    if (tipTempMax > tiptempMin) {
      // Have been heating for min seconds, check if the delta is large enough
      TemperatureType_t delta = tipTempMax - tiptempMin;
      haveSeenDelta           = true;

      if (delta < THERMAL_RUNAWAY_TEMP_C) {
        heaterThermalRunaway = true;
      }
    }

@discip
Copy link
Collaborator

discip commented Dec 16, 2024

@Eheran1
If you need to edit a post, you can do so at any time by clicking on the 3 dots in the top right corner of the post and selecting Edit.
Just so you don't have to repost everything multiple times. 😊

@Tekz42
Copy link
Author

Tekz42 commented Jan 28, 2025

@Ralim Sorry for the extremely late reply, life has been busy elsewhere. Thankfully the retune has solved the issue as of late. Im still to put more time in but it's looking promising. Thank you so much.

@Ralim
Copy link
Owner

Ralim commented Feb 4, 2025

@Tekz42 No problem, late feedback is better than none. Glad to hear its helping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or additional function. Next Release Items for next release consideration.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants