-
-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to switch A and B button for settings #2034
Comments
Fair enough, should be reasonable to do. One question; in your mind, how should this play with the existing +/- swap option?. I.e if that option is on but the new one is off, are they still swapped in the menu? |
I would say they could't interfere with each other, because the +/- swap is only when changing temperature while soldering and the A/B should be only in the settings menu, neither in the main menu, nor the soldering menu, nor the debug menu, they all make sense to my brain right now. Thank you very much! |
TL;DR: in fact, I could agree with you that this could be useful option for some people, especially those who are new ones to use IronOS: for some reason in the beginning of using IronOS my brain always did try to use "B" as "the enter" (probably you're right - since it's closer to a display), and "A" as more like "change/back/scroll" (to the opposite defaults). @CakeIsYummy21, your report is very funny (in a good way)! Because to be fully honest, this was the very first thing which was bothering me when I booted up IronOS and ended up in the settings for the first time. I even was starting to work on a patch doing exactly what you suggest now, but, first of all, we were running out of free flash space back then for some models of supported hardware (so there was no space physically for new code & features), and, second, by the time I started to make other improvements, I just did get used to the controls, LOL. :) |
LOL |
@Ralim, if you don't mind I would like to work on this one. And I fully agree with @CakeIsYummy21 - the new option should be fully independent from anything else and affects buttons' behavior only in menu. |
Yes-yes, now it shouldn't be a problem, thanks to the huge refactoring by @Ralim. |
@ia Always feel free to grab things if you have an interest to do them 😁 |
getButtonState() now have an option int/bool argument to swap the result via XOR
Is your feature request related to a problem? Please describe.
I always mess up A & B button when in settings menu, the B button feels more like a set button to me and the A more like a selection button, because the B button is closer to the display.
Describe the solution you'd like
An option in the settings menu to switch A and B button for the settings menu, in the user interface tab, next to + - button switch.
The text was updated successfully, but these errors were encountered: