Fix echo in top-level Makefile for some environments #1737
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix a tiny bug in the top-level
Makefile
.What is the current behavior?
In some environments (such as docker shell inside
alpine 3.16
) instead of transforming escape sequences on output respectively, output shows\t
s and\n
's as is.What is the new behavior (if this is a feature change)?
Replace
\t
s and\n
's by spaces and outputs of new lines explicitly.Other information:
Also I took some liberty to switch
WORKDIR
for the container. Currently, after you start a docker shell and want to do something with sources, you must manually do extra command (likecd source
) to jump into source tree to keep working with scripts & sources. This little change eliminates that by allowing seamlessly keep using exactly the samemake
/./scripts/
commands as if you wouldn't left the current IronOS source tree directory on host, i.e.:vs
As far as I understand from official docker documentation,
WORKDIR
is usually used to avoid providing absolute path for docker file commands such asCOPY
, but since in IronOS DockerfileCOPY
commands are copying files using absolute paths for destinations inside of a container, then such change shouldn't break anything but it will be way much convenient on jumping to the container from source tree.