Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued work on Pinecil v2 doesn't work after updating to v2.21 #1661.
@gamelaster tracked down the issue for the crash was the args to printf being bad causing invalid args to
malloc
. This occurs in the binary blob for BLE, so not trivial to fix or patch.Luckily by remapping
printf
at link time to redirect to the bfl implementation it lines up.Now this appears that on the failing unit it will print
roscal fail
, which we have NFI what it means.It appears to be a warning something internally failed to calibrate (we are guessing an RC Oscillator) but also we have found that otherwise it appears to continue with BLE working (on a sample unit count of 1).
At the least this looks to prevent the crash. Further testing to be done on if any impacts otherwise.
Would suuper love reports of this working or failing.
EDIT:
Seems to fix #1661