push.yml: probable fix #1764 #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix Multi-lang builds of Pinecilv2 fail with ld/lto1 errors #1764 bug (but maybe introduces new bugs).
What is the current behavior?
Multi-lang builds for PinecilV2 crash with link-related errors due to nuances of calling multiple targets in parallel using external helper Makefile.
What is the new behavior (if this is a feature change)?
Hopefully fixing crashes of multi-lang builds for PinecilV2 by calling
source/Makefiledirectly using-Coption without involving top-levelMakefile.Other information:
See Multi-lang builds of Pinecilv2 fail with ld/lto1 errors #1764 issue report for the full details.
This probable fix has been tested locally. While problematic behavior is reproducible with 99% rate, after just switching a call from
maketomake -Cintest.shmore than dozen builds have been done successfully without any related issues to compiling & linking.