Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable short press of + button to change temperature to prevent accidentally changing temp only when using boost mode. #2054
base: dev
Are you sure you want to change the base?
Disable short press of + button to change temperature to prevent accidentally changing temp only when using boost mode. #2054
Changes from 57 commits
933e2cc
2bd7b81
9b3effe
450d129
27de7f5
95493b4
fc7aaf2
6632065
9e8bd8e
5b5200a
ab5f5b2
5e8cd33
f759195
cb66787
7fc12da
07457af
b005870
4a1e946
ff213aa
eca4a23
b37c420
522822b
c2c1cab
f6c864d
8c538a2
0fdc052
72a7cf3
9d26f8b
5a67f06
84c61aa
058f04f
211c172
0fa48ed
32d9577
67ecb2d
ea14714
1e756b4
509e6a8
050fa82
d7a58e5
6e30c78
7c26647
a525944
52c4087
30c9ac8
d9d421f
60e3f1d
4286358
78686a8
1b45b36
e1340ad
daca0e6
82a0328
98755f0
06629c6
7869b28
d6c04a0
a712e8d
7bf9620
7e1dfc0
911ef59
6a549b6
14cca01
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my humble opinion, the description is a bit of confusing. As far as I understand from the brief review of the original bug report and this pull-request, basically it should sound something like: Shown when the locking mode is set to lock only A/+ button.
Please, correct me if I'm wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I worded it like this because the nature of the mode is much more different than the other locking modes.
It's not entirely locking the A/+ button, only part of it's functionality,
Would this be a better description?