Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to pass a custom object to
Instance::create_session()
used to force a specific drop order. In particular, in case the graphics device and instance is kept around in a clonable object (with a properimpl Drop
) and its time of destruction is unknown, thedrop_guard
argument should be set to a clone of this object. For context, here is a related PR: gfx-rs/wgpu#1609This is needed for OpenXR support in bevy. Until now this solution was used:
Instead of exposing
openxr::Session
to the user directly, thisOpenXrSession
object is used. But the underlyingopenxr::Session
is still cloned by the bevy plugin implementation (for interop with graphics), and this makes it tricky to ensure safety.The vulkan example is updated, but it passes
None
as the drop guard since the drop order is already enforced and the example is linear.