Removed unused variable

RallySoftware · May 8, 2020 · c612f93 · c612f93
1 parent bd82212
commit c612f93
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/mujina-idp/src/main/java/mujina/idp/MetadataController.java b/mujina-idp/src/main/java/mujina/idp/MetadataController.java
@@ -78,9 +78,6 @@ public String metadata(@Value("${idp.base_url}") String idpBaseUrl) throws Secur
 
     idpssoDescriptor.addSupportedProtocol(SAMLConstants.SAML20P_NS);
 
-    String localPort = environment.getProperty("local.server.port");
-
-
     SingleSignOnService singleSignOnService = buildSAMLObject(SingleSignOnService.class, SingleSignOnService.DEFAULT_ELEMENT_NAME);
     singleSignOnService.setLocation(idpBaseUrl + "/SingleSignOnService");
     singleSignOnService.setBinding(SAMLConstants.SAML2_REDIRECT_BINDING_URI);

diff --git a/mujina-idp/src/test/java/mujina/idp/MetadataControllerTest.java b/mujina-idp/src/test/java/mujina/idp/MetadataControllerTest.java
@@ -2,6 +2,7 @@
 
 import mujina.AbstractIntegrationTest;
 import org.junit.Test;
+import org.springframework.beans.factory.annotation.Value;
 
 import static io.restassured.RestAssured.given;
 import static io.restassured.config.RestAssuredConfig.newConfig;
@@ -11,6 +12,9 @@
 
 public class MetadataControllerTest extends AbstractIntegrationTest {
 
+  @Value("${idp.base_url}")
+  private String idpBaseUrl;
+
   @Test
   public void metadata() throws Exception {
     given()
@@ -22,7 +26,7 @@ public void metadata() throws Exception {
       .statusCode(SC_OK)
       .body(
         "EntityDescriptor.IDPSSODescriptor.SingleSignOnService.@Location",
-        equalTo("http://localhost:8080/SingleSignOnService"));
+        equalTo(idpBaseUrl + "/SingleSignOnService"));
   }
 
 }