Merge pull request #230 from RamiAwar/S14.Z-mysql-connection-support

Add mysql python connector used by sqlalchemy
RamiAwar · Jun 30, 2024 · 5b30a37 · 5b30a37
2 parents 9dc0fe9 + 4724c65
commit 5b30a37
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 15 deletions.
diff --git a/backend/dataline/models/connection/schema.py b/backend/dataline/models/connection/schema.py
@@ -114,6 +114,8 @@ def validate_dsn(value: str) -> str:
  if value.startswith("postgres") and not value.startswith("postgresql"):
  # Only replace first occurrence
  value = value.replace("postgres", "postgresql", 1)
+ elif value.startswith("mysql"):
+ value = value.replace("mysql", "mysql+pymysql", 1)
 
  return value
 

diff --git a/backend/poetry.lock b/backend/poetry.lock
diff --git a/frontend/src/assets/images/mysql.png b/frontend/src/assets/images/mysql.png
diff --git a/frontend/src/components/Connection/DatabaseDialectImage.tsx b/frontend/src/components/Connection/DatabaseDialectImage.tsx
@@ -2,6 +2,7 @@ import React from "react";
 import postgresImage from "../../assets/images/postgres.png";
 import sqliteImage from "../../assets/images/sqlite.png";
 import snowflakeImage from "../../assets/images/snowflake.png";
+import mysqlImage from "../../assets/images/mysql.png";
 import { CircleStackIcon } from "@heroicons/react/24/outline";
 
 interface DatabaseDialectImageProps {
@@ -15,13 +16,14 @@ const DatabaseDialectImage: React.FC<DatabaseDialectImageProps> = ({
  postgresql: postgresImage,
  sqlite: sqliteImage,
  snowflake: snowflakeImage,
+ mysql: mysqlImage,
  // You can add more mappings here as needed
  };
 
  const imageSrc = imageMap[databaseDialect];
 
  if (!imageSrc) {
- return <CircleStackIcon className="text-gray-400" />;
+ return <CircleStackIcon className="text-gray-400 h-full" />;
  }
 
  return <img className="h-full" src={imageSrc} alt={databaseDialect} />;