Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Stored sql run result #222

Merged
merged 1 commit into from
Jun 25, 2024
Merged

feat: Stored sql run result #222

merged 1 commit into from
Jun 25, 2024

Conversation

RamiAwar
Copy link
Owner

WIP

  • Store sql run result
  • Add delete result button (otherwise problematic for results with massive limits)
  • Enforce limits by default (user-overridable)
  • When query is replayed, delete old result and replace with new data + creation date
  • Add refresh button to table result (does the same as above)
  • Add created_at date to table result (maybe make hideable, iterate on designs) (necessary for dashboards later)

anthony2261
anthony2261 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@anthony2261 anthony2261 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I like the review by sub-task / chunk method

@RamiAwar RamiAwar merged commit d3cc864 into main Jun 25, 2024
4 checks passed
@RamiAwar RamiAwar deleted the S14-stored-run-results branch June 25, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthony2261 anthony2261 anthony2261 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RamiAwar @anthony2261