feat: Added excel file support #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamiAwar
approved these changes
Jul 13, 2024
|
LGTM! Would be good to show an "excel parsing error" on the frontend rather than the generic error if parsing fails |
peter-gy
added a commit
to peter-gy/dataline
that referenced
this pull request
Aug 14, 2024
Follow-up for RamiAwar#256
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for excel files.
Offline parser would try to intelligently figure out where the header row + the first non-null column is.
Note: failures are not handled well yet, but it won't succeed if the file isn't in the correct format.