Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle schemas and tables. FE, BE, the whole package. #302

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

anthony2261
Copy link
Collaborator

Initial Notes:

  • what do we want the behavior to be when the DSN changes during a connection update? I say we enable everything we find in the new dsn, it could be a different database!
  • With this change, the schema will always be shown, even for databases with one schema. For example, sqlite dbs can only have one schema named "main", and it will show up in the generated SQL, for example: SELECT * from main.purchases.
  • Tested this with sqlite, postgres, sql server and mysql
compressed.mp4

@anthony2261 anthony2261 linked an issue Aug 15, 2024 that may be closed by this pull request
backend/dataline/models/connection/model.py Outdated Show resolved Hide resolved
backend/dataline/services/llm_flow/utils.py Outdated Show resolved Hide resolved
@RamiAwar RamiAwar merged commit 78ca46d into main Aug 22, 2024
4 checks passed
@RamiAwar RamiAwar deleted the S18.1-enable-disable-schemas-and-tables branch August 22, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S18.1 - Enable / Disable Schemas and Tables
2 participants