Improve table name validation in InfoSQLDatabaseTool #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix for bug where follow-up questions were causing the LLM to fail in finding tables. The issue stemmed from inconsistent table naming conventions ("public.table" vs "table"). The LLM was unable to locate "public.table" when queried about "table". |
- Extract table name validation logic to _validate_table_names method - Improve handling of table names with and without schema prefixes - Simplify _run method by using the new validation function - Use set for valid tables to avoid duplicates
anthony2261
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
available_names_tables_onlyto store table names without schema prefixes.