Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny fixes #341

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Tiny fixes #341

wants to merge 1 commit into from

Conversation

anthony2261
Copy link
Collaborator

  • return toolmessage with error if LLM calls QuerySQLDataBaseTool without for_chart
  • use gpt-4o-mini for title generation

- return toolmessage with error if LLM calls QuerySQLDataBaseTool without for_chart
@RamiAwar
Copy link
Owner

RamiAwar commented Oct 8, 2024

Handling a bad tool call such as this seems like it should be the responsibility of whatever LLM calling framework we're using, not good to start handling these manually.

Maybe we should look at what's being used here and fix the issue at the higher level automatically (by enforcing a structure for the sqldb tool call I mean). Makes sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants