Export Data working #342
Draft
Export Data working #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
anthony2261
commented
Oct 5, 2024
•
anthony2261
commented
- Stream results BE -> FE
- Stream results SQL -> BE
- Validate that we can export the data for the given result_id
RamiAwar
reviewed
Oct 10, 2024
| def custom_run_sql_stream(self, query: str) -> Generator[Sequence[Row[Any]], Any, None]: | ||
| # https://docs.sqlalchemy.org/en/20/core/connections.html#streaming-with-a-fixed-buffer-via-yield-per | ||
| yield_per = 1000 | ||
| if self.dialect == "mssql": |
There was a problem hiding this comment.
This is becoming a little annoying seeing all these if-statements everywhere. Idk if it's time for this yet, cause it's still acceptable, but we should at least start thinking about using some better design pattern here, ex. Command pattern or something where based on the Dialect, the functionality is housed in one place.
RamiAwar
reviewed
Oct 10, 2024
RamiAwar
reviewed
Oct 10, 2024
| result_service: Annotated[ResultService, Depends(ResultService)], | ||
| background_tasks: BackgroundTasks, | ||
| ) -> StreamingResponse: | ||
| background_tasks.add_task(posthog_capture, "results_exported") |
There was a problem hiding this comment.
I'd be a bit more specific here - export results as csv maybe. Will probs have diff kinds of exports in the future.
There was a problem hiding this comment.
Same with function/route name maybe
RamiAwar
reviewed
Oct 10, 2024
|
|
||
|
|
||
| @router.get("/result/{result_id}/export-url") | ||
| async def export_csv_url(request: Request, result_id: UUID) -> SuccessResponse[str]: |
There was a problem hiding this comment.
Don't understand why we need this
RamiAwar
reviewed
Oct 10, 2024
RamiAwar
reviewed
Oct 10, 2024
| @@ -103,6 +107,17 @@ export const DynamicTable: React.FC<{ | |||
| </button> | |||
| </CustomTooltip> | |||
| ))} | |||
| {data.rows.length > 1 && linked_id && ( | |||
| <CustomTooltip hoverText="Export"> | |||
There was a problem hiding this comment.
A bit too wordy no?
RamiAwar
requested changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.