Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed an animation fix #204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

congliu0704
Copy link

@congliu0704 congliu0704 commented Oct 7, 2021

Summary

  1. Fixed scroll-to-bottom condition so that both sides are relative y-coordinates. cell.frame.maxY > tableView.frame.maxY should be cell.frame.maxY > tableView.frame.maxY + tableView.contentOffset.y
  2. Enabled scrolling to the top of the cell, when some of top part of this cell is across the upper edge of the table view (that is, hidden) and is tapped to unfold.

1. Fixed scroll-to-bottom condition so that both sides are relative y-coordinates. cell.frame.maxY > tableView.frame.maxY should be cell.frame.maxY > tableView.frame.maxY + tableView.contentOffset.y
2. Enabled scrolling to the top of the cell, when some of top part of this cell is across the upper edge of the table view (that is, hidden) and is tapped to unfold.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant