-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup travis & coverage #1
Comments
Hi, I came from hacktoberfest and would like to work on this |
Thanks @recurza ( we probably need to npm i --save istanbul coveralls ) then follow https://github.com/nickmerwin/node-coveralls#istanbul That requires setting a .yml.coveralls with a config, there should be a quick tutorial out there let me if you still want to take it / need some help 👍 |
Sure I'll try to set it up 😁 |
I'm a bit confused: the coveralls website said Travis users don't need a coveralls.yml. So we are using istanbul instead of travis? |
You're right @recurza we don't need a yml file 👍 So mocha is the testing framework, istanbul is coverage library which determines how much is covered by the tests, and travis is the continuous integration which runs all these on every pull request. the tests are currently in api/**/*.test.js (passing this to mocha should have found them) even after this is set up, istanbul reports "no coverage information found", this is probably linked to gotwarlost/istanbul#262, which suggested using babel-istanbul. switching to babel-istanbul worked.. but it wasn't as straight forward as i thought.. so sorry about that ;) let me know if you have any questions |
oh I see. Thanks for explaining :) |
Thank you for looking into it 💯 |
and add to readme
The text was updated successfully, but these errors were encountered: