-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for the latest Vega v5.x releases #19
Comments
I would like to use a local version during development. This would be similar to vscodes support for local typescript. |
I still don't get what you mean by that 'local' vega libs part. There is no such thing as local vega js libs. I've tried to make that happen with Vega Viewer tho. TS comes packaged with vscode, and extensions can link the TS v. they use or pull, and I already do that in this ext. since it's coded in TS. However, how do you see this work with vega libraries? I thought inspecting vega json, pulling I still need to know that mapping tho. Does vega Editor do it today? Can you link me to that setup to see how you handle it online? Also, what older vega || vega-lite examples/specs don't work with the current setup in this ext? I've tested latest v. with your older vega json examples and did not find a single spec that failed to render. I could easily inject diff. |
In the Vega editor, I use yarn link to connect the current dev version. This way I can make changes to Vega and Vega-Lite and still try them in the Editor. Does this explain my use case? |
nope. I do the same in my I hope that explains it on my end. Please provide mapping from your older json schema's to your vega lib releases, and I'll add support for older vega json specs. I'd rather do it for all versions in the wild you think devs might need to use for their vega || lite charts previews. |
also, if you want to do it in Vega Viewer the way you describe it, then you can run dev build of this extension and change those vega lib references as you see fit. I just don't think it's what any vega charts dev would do. Does that make it work for you? See Dev Build section in my readme :) |
Sounds good. The mapping is at https://github.com/vega/schema/tree/master/vega-lite (see the symlinks). We follow semantic versioning practices. |
thanks for that mapping link. I can make a change to pull would love other devs using vega or working on vega pitch in on this change and make it work for all, core vega viz team & devs using them. |
currently this extension provides
vg.json
andvl.json
Previews using embedded Vega v4 and Vega-Lite v3 libraries.Vega dev team, @jheer and @domoritz have been busy with new Vega v5 updates recently.
I'd like to support latest Vega library updates to Preview vega json files created with new features and changes in v5.x. See Vega repo for more info:
https://github.com/vega/vega/releases
Ultimately and ideally as part of this viewer update, load correct vega, vega-lite or vega-embed version for Preview based on the Vega $schema reference provided in
vg.json
||vl.json
spec for backward compatibility and previews of older vega specs.The text was updated successfully, but these errors were encountered: