support for multiple apps #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
aaronshaf
commented
Jul 16, 2018
•
aaronshaf
commented
- .dat-pub/{application key}.json
- rename endpoint -> /applications/{dat-key}/archives
- resolve dat urls
RangerMauve
previously requested changes
Jul 16, 2018
applications.js
Outdated
| }) | ||
|
|
||
| // if I load prematurely, it doesn't work | ||
| sleep(3000).then(loadAllArchives) |
There was a problem hiding this comment.
Should there be an await here?
There was a problem hiding this comment.
No, dat location can be immediately returned, even before the hub begins to successfully host it.
utils.js
Outdated
| file = await userArchive.readFile(proofLocation) | ||
| } catch (err) { | ||
| throw new Error( | ||
| `Proof file missing: /.well-known/dat-pubs/${applicationPub.url.slice( |
There was a problem hiding this comment.
Should replace this with Proof file missing: ${proofLocation} to make it easier to change the location in the future.
|
Worth another look |
|
Looks like I should use Nevermind. I'll do that in a future version. |
RangerMauve
requested changes
Jul 30, 2018
| const { join, basename } = require('path') | ||
| const mkdirp = require('mkdirp') | ||
|
|
||
| const APPLICATIONS_DIR = join(__dirname, 'applications') |
There was a problem hiding this comment.
I think this should be configurable by the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.