Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #31

Merged
merged 2 commits into from
Aug 27, 2019
Merged

Update README.md #31

merged 2 commits into from
Aug 27, 2019

Conversation

DougAnderson444
Copy link
Contributor

The wording "will run in the background" is confusing. Is it really needed? Does it run the service or just install it? "Run" is the same word as-in "run-service" in the line above, which may be mistaken as "does the same thing as run-service". If it's just an installer, then installing in the background is a given. Just a suggestion :)

@RangerMauve
Copy link
Owner

Yeah, that makes sense. Would you mind adding the change in wording to index.js too? 😁

@DougAnderson444
Copy link
Contributor Author

Ok! Done :)

Copy link
Owner

@RangerMauve RangerMauve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet. Thank you! 😁

@RangerMauve RangerMauve merged commit d8dcd09 into RangerMauve:master Aug 27, 2019
@RangerMauve
Copy link
Owner

Out in 4.0.1 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants