LOAD blocks cannot be placed within a ROM section

Fixes gbdev#576
Rangi42 · Dec 16, 2020 · fd268da · fd268da
1 parent 1d9cc01
commit fd268da
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 0 deletions.
diff --git a/src/asm/section.c b/src/asm/section.c
@@ -339,6 +339,9 @@ void out_SetLoadSection(char const *name, uint32_t type, uint32_t org,
 	if (currentLoadSection)
 		fatalerror("`LOAD` blocks cannot be nested\n");
 
+	if (sect_HasData(type))
+		fatalerror("`LOAD` blocks cannot be placed within a ROM section\n");
+
 	struct Section *sect = getSection(name, type, org, attribs, false);
 
 	loadOffset = curOffset;

diff --git a/test/asm/load-rom.asm b/test/asm/load-rom.asm
@@ -0,0 +1,5 @@
+SECTION "Hello", ROM0
+	ld a, 1
+LOAD "Wello", ROM0
+	ld a, 2
+ENDL
diff --git a/test/asm/load-rom.err b/test/asm/load-rom.err
@@ -0,0 +1,2 @@
+FATAL: load-rom.asm(3):
+    `LOAD` blocks cannot be placed within a ROM section
diff --git a/test/asm/load-rom.out b/test/asm/load-rom.out
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		FATAL: load-rom.asm(3):
		`LOAD` blocks cannot be placed within a ROM section