on_member_join not working

[ghost]

@bot.event
async def on_member_join(ctx):
    user = ctx.author
    if not user.bot:
        server = ctx.guild
        now = datetime.now()
        dt_string = now.strftime("on %d/%m/%Y at %H:%M")
        embed = discord.Embed(
            title=f"",
            description=f"{user.mention} **Joined The Server**",
            colour=user.colour,
            )
        embed.set_author(name=f"{user}", icon_url=f"{user.avatar_url}")
        embed.set_thumbnail(url=user.avatar_url)
        embed.add_field(name="User id:", value=f"{user.id}")
        embed.set_footer(text=f"{dt_string}")
        await ctx.send(embed=embed)
    else:
        await ctx.send("A Fricking bot joined the server")

why is this thing not working on member join never works for me
can someone help

[AbstractUmbra]

Assuming you have updated to discord.py 1.5.0, you will be missing the intents required for this event to trigger.

You will need the guilds and members Intents at a minimum.

[ghost]

intents = discord.Intents.default()
intents.members = True

client = discord.Client(intents=intents)

would that fix it

[ioistired]

yes that should fix it

[ghost]

well it did not work at all no error message no nothing

import discord
from discord.ext import commands
from datetime import datetime

import json
import os

if os.path.exists(os.getcwd() + "/config.json"):
    
    with open("./config.json") as f:
        configData = json.load(f)

else:
    configTemplate = {"Token": "", "Prefix": "."}

    with open(os.getcwd() + "/config.json", "w+") as f:
        json.dump(configTemplate, f) 

token = configData["Token"]
prefix = configData["Prefix"]

bot = commands.Bot(command_prefix='.')
bot.remove_command("help")
intents.members = True
intents.guild = True
client = discord.Client(intents=intents)

@bot.event
async def on_ready():
    print('{0.user} Online'.format(bot))
    await bot.change_presence(activity=discord.Activity(type=discord.ActivityType.watching, name="People Join"))

@bot.event
async def on_member_join(ctx):
    user = ctx.author
    intents = discord.Intents.default()
    if not user.bot:
        server = ctx.guild
        now = datetime.now()
        dt_string = now.strftime("on %d/%m/%Y at %H:%M")
        embed = discord.Embed(
            title=f"",
            description=f"{user.mention} **Joined The Server**",
            colour=0x73D673,
            )
        embed.set_author(name=f"{user}", icon_url=f"{user.avatar_url}")
        embed.set_thumbnail(url=user.avatar_url)
        embed.add_field(name="User id:", value=f"{user.id}")
        embed.set_footer(text=f"{dt_string}")
        await ctx.send(embed=embed)
    else:
        pass

@bot.command()
async def test_welcome(ctx):
    user = ctx.author
    if not user.bot:
        server = ctx.guild
        now = datetime.now()
        dt_string = now.strftime("on %d/%m/%Y at %H:%M")
        embed = discord.Embed(
            title=f"",
            description=f"{user.mention} **Joined The Server**",
            colour=0x73D673,
            )
        embed.set_author(name=f"{user}", icon_url=f"{user.avatar_url}")
        embed.set_thumbnail(url=user.avatar_url)
        embed.add_field(name="User id:", value=f"{user.id}")
        embed.set_footer(text=f"{dt_string}")
        await ctx.send(embed=embed)
    else:
        pass

@bot.command()
async def ping(ctx):
    user = ctx.author
    latency = round(bot.latency * 1000, 1)
    embed = discord.Embed(title="PING", description=f"[:white_check_mark:] \n\n{latency}ms", colour=0xEED749)
    await ctx.send(embed=embed)

@bot.command(description="Displays the help")
async def help(ctx, Any_command=None):
    if Any_command != None:

        for command in bot.commands:
            if Any_command.lower() == command.name.lower():

                paramString = ""

                for param in command.clean_params:
                    paramString += param + ", "

                paramString = paramString[:-2]

                if len(command.clean_params) == 0:
                    paramString = "None"
                    
                embed=discord.Embed(title=f"HELP - {command.name}", description=command.description)
                embed.add_field(name="parameters", value=paramString)
                await ctx.send(embed=embed)
        
    else:
        embed = discord.Embed(title="Help", description="")
        embed.add_field(name="**ping**", value="shows the latency of the bot", inline=False)
        embed.add_field(name="**help**", value="shows this message", inline=False)
        embed.add_field(name="**test_welcome**", value="shows the welcome message example", inline=False)
        await ctx.send(embed=embed)

bot.run(token)

HELP!!!! adding the intents thing did not help at all

[Herbstblatt]

You are using both Bot and Client. You're creating the Client instance and applying intents to it, but it doesn't affect your bot. You should do something like this:

intents = discord.Intents.default()
intents.members = True
bot = commands.Bot(command_prefix='.', intents=intents)
bot.remove_command("help")

[ghost]

You are using both Bot and Client. You're creating the Client instance and applying intents to it, but it doesn't affect your bot. You should do something like this:

intents = discord.Intents.default()
intents.members = True
bot = commands.Bot(command_prefix='.', intents=intents)
bot.remove_command("help")

thats the answers

[NESTOWL]

Sometimes the on_member_join event won't fire!
This is very infuriating, for a long time so (
that on the old version sometimes it does not work that on the new one!
Although lately it seems work

[ghost]

is there any alternative to it , like to make it work or sometihing

[NESTOWL]

you can set up a log chat


and make the bot read these messages
personally I'm going to do this, but there is no time!

[NESTOWL]

This is of course a crutch solution, but it will work 100%

[ghost]

no i wanted it to send an embed, i mean if i wanted any welcome message i would go for some other bot so that's not a solution i would like but appreciate the effort thanks

[NESTOWL]

no i wanted it to send an embed

Well it can be done!

exemple:

async def on_message(message):
    if message.type is discord.MessageType.new_member and message.guild.id == SERVER_ID:
        embed = discord.Embed(description=f'Hello {message.author.mention} !!!')
        log_channel = message.guild.get_channel(CHANNEL_LOG_ID)
        await log_channel.send(embed=embed)

in theory it should work! I have not tested
wrote in a quick hand as an example