-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
patching doc extensions to work with later sphinx versions #9556
base: master
Are you sure you want to change the base?
Conversation
…inx release. It's able to make after this.
backwards compatibility with 4.4.0.
I'm running into this same issue. Note that >>> datetime.datetime.now().astimezone().tzinfo
datetime.timezone(datetime.timedelta(days=-1, seconds=72000), 'Eastern Daylight Time') |
Actually, it's probably best to just use the old code in the except Exception as exc:
from sphinx.buildert.gettext import timestamp, ltz
ctime = datetime.datetime.fromtimestamp(timestamp, ltz).strftime('%Y-%m-%d %H:%M%z') |
I was considering replacing the ctime calculation used in the except block with the ctime calculation used in the later sphinx build, but your way would work out better. |
Rather than doing the compatibility just bump the version along with the changes. |
bumping to latest sphinx 7.2.6 version in setup.py (I hope this is the right way to do it.) Included a copy of basic.css to prevent visited hyperlinks from turning purple. favicon now shows up.
Outside of a deprecation warning for status_iterator (which I patched), the extensions now work with the latest sphinx version (7.2.6). |
Added the cosmetic rules to style.css instead. |
Might be useful to run |
I didn't run black and isort originally, I did so in this commit. |
fix for
doc/extensions/builder.py
to allow for compatibility with sphinx 7.2.5 and up.Summary
Checklist