New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] app commands guide #9557

Draft

ika2kki wants to merge 41 commits into Rapptz:docs/guide from ika2kki:guide/slash-commands

Contributor

ika2kki commented Sep 11, 2023 •

edited

Loading

Summary

app commands guide drafting
i have a built version hosted here to make it accessible if you want to read it https://saya.kessoku.moe/discord.py/guide/interactions/slash_commands.html
it can be slightly old if i forgot to update it after a commit.
so far, i am kinda happy with the content but not so much the overall writing tone

Checklist

If code changes were made then they have been tested.
- I have updated the documentation to reflect the changes.
This PR fixes an issue.
This PR adds something new (e.g. new method or parameters).
This PR is a breaking change (e.g. methods or parameters removed/renamed)
This PR is not a code change (e.g. documentation, README, ...)


          add slash commands guide

086c60e

Willy-C reviewed

View reviewed changes

docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved

ika2kki added 2 commits

September 11, 2023 12:29


          touch on message content intent availability

558db50


          actually enable the intent and fix typo

61f3ff0

Jerrie-Aries suggested changes

View reviewed changes

docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved

ika2kki added 6 commits

September 15, 2023 04:55


          autocomplete and translating (wip)

c85e8e9


          union can be used to accept both user types

ae605b7


          group examples for checks and outdated commands

42d92ac


          reorder topics and rename, change example

1df4740


          changed my mind

373933b


          kind of a skill issue

06c7045

Willy-C reviewed

View reviewed changes

docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved

tailoric reviewed

View reviewed changes

Contributor

tailoric left a comment

Read through it once and annotated what I've found and gave some opinions
However, I skimmed the translation part only, since I have no experience in that area.

docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved

docs/guide/interactions/slash_commands.rst Show resolved Hide resolved

docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved

docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved

docs/guide/interactions/slash_commands.rst Show resolved Hide resolved

docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved

docs/guide/interactions/slash_commands.rst Show resolved Hide resolved

docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved

ika2kki added 2 commits

September 21, 2023 15:23


          feedback

d8cb7f1


          missing image for outdated commands

2c7bc56

No767 reviewed

View reviewed changes

docs/guide/interactions/slash_commands.rst Show resolved Hide resolved

ika2kki force-pushed the guide/slash-commands branch from 283cf24 to 2c7bc56 Compare

October 1, 2023 23:04

ika2kki added 7 commits

October 2, 2023 10:14


          Merge branch 'docs/guide' of https://github.com/Rapptz/discord.py int…

6ebcf1b

…o guide/slash-commands


          error handling, expand a bit on guild commands and some cleanup

7113da5


          ascii tree was wrong and use a relative path instead

dd58d82


          write custom checks, collapse some examples, other cleanups

a623e26


          that cooldown will fail for dms

9dea4bb


          normalise string literals to be more inline with project


          didnt like the repeat command

f09b0e7

No767 suggested changes

View reviewed changes

docs/guide/interactions/slash_commands.rst Show resolved Hide resolved

docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved

docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved

docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved

Gobot1234 reviewed

View reviewed changes

docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved

ika2kki added 2 commits

October 7, 2023 08:36


          add a note on when not to sync

9c013ee


          change numpy/google/sphinx examples to use inline tabs ext

c7f11dd

Gobot1234 reviewed

View reviewed changes

docs/guide/interactions/slash_commands.rst Show resolved Hide resolved

Gobot1234 reviewed

View reviewed changes

Contributor

Gobot1234 left a comment

Feel free to ignore the comments about decorators (IDR what other guides do)

docs/guide/interactions/slash_commands.rst Show resolved Hide resolved

docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved

docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved

docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved

docs/guide/interactions/slash_commands.rst Show resolved Hide resolved

docs/guide/interactions/slash_commands.rst Show resolved Hide resolved

docs/guide/interactions/slash_commands.rst Show resolved Hide resolved

docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved

docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved

docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved

ika2kki and others added 16 commits

October 7, 2023 12:18


          link to proper pep and use the pep directive

Co-Authored-By: James Hilton-Balfe <gobot1234yt@gmail.com>


          add missing ellipsis to example

34d08ef

Co-Authored-By: James Hilton-Balfe <gobot1234yt@gmail.com>


          use module directive for stdlibs

e2c1567

Co-Authored-By: James Hilton-Balfe <gobot1234yt@gmail.com>


          add missing link to stderr ref

05ffda3

Co-Authored-By: James Hilton-Balfe <gobot1234yt@gmail.com>


          use = in f-string expression for add command

9d28be9

Co-Authored-By: James Hilton-Balfe <gobot1234yt@gmail.com>


          clarify wording on subclassing groups

cd55a54

Co-Authored-By: James Hilton-Balfe <gobot1234yt@gmail.com>


          redo some wording for typing.Union

684b1e7


          try to tidy error handling section and improve flow

8c6e8a9


          english

a6a9994


          cover commands showing up twice and a warning on syncing globally

a9c1077


          unhappy with the fluent example

ed51795


          try and improve explanation for USER discord type

ead8f01


          expand a bit on extras for locale string

3b91e08


          prefix each anchor with _guide_slash_commands like how other guides d…

7b29de5

…o it


          respond in the cmd example

0e236dd


          dont remember what i changed

0d96107

No767 reviewed

View reviewed changes

docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved

ika2kki and others added 2 commits

December 3, 2023 22:02


          random? changes

0f2c78b


          i like this word more

c765195

Co-Authored-By: Noelle Wang <73260931+no767@users.noreply.github.com>

No767 suggested changes

View reviewed changes

No767 left a comment

Everything looks pretty good to me. There are a couple of minor phrasing issues that should be pointed out

docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved

docs/guide/interactions/slash_commands.rst Outdated Show resolved Hide resolved

docs/guide/interactions/slash_commands.rst Show resolved Hide resolved

ika2kki added 2 commits

January 12, 2024 03:31


          interaction stuff

1e6a5ac


          rephrase autocomplete rundown

e7f85d5

No767 approved these changes

View reviewed changes

No767 left a comment

Just looked at the recent changes, and they all look good to me.


          reword intro a bit

f63a31e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tailoric tailoric left review comments

Willy-C Willy-C left review comments

Gobot1234 Gobot1234 left review comments

Jerrie-Aries Jerrie-Aries requested changes

No767 No767 approved these changes

Labels

None yet