Sharding Guide #9562
Open
Sharding Guide #9562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot to swap this from draft to ready to review (I know this is still incomplete but I do not know what else to add.) |
Willy-C
suggested changes
Sep 29, 2023
Co-authored-by: Willy <19799671+Willy-C@users.noreply.github.com>
Co-authored-by: Willy <19799671+Willy-C@users.noreply.github.com>
pythonmcpi
reviewed
Dec 2, 2023
fretgfr
reviewed
Dec 3, 2023
AbstractUmbra
suggested changes
Jan 27, 2024
There was a problem hiding this comment.
Great start just a few comments from myself.
The PR comments themselves and some more:-
- It'd be good to have a strongly worded footnote or small end-of-topic go-over of the sharding formula and why it's necessary.
- There seems to be no mention of the DM limitation, that Shard 0 is the only shard to receive DMs.
- More explanation on the shard_count and shard_ids parameters of the constructors of the relevant classes. It's okay to mention them but I'd like to understand them better, at least at a glance.
Void-ux
reviewed
Jan 27, 2024
Co-authored-by: Alex Nørgaard <Umbra@AbstractUmbra.dev>
Co-authored-by: Dan <77840397+Void-ux@users.noreply.github.com>
Co-authored-by: Dan <77840397+Void-ux@users.noreply.github.com>
Co-authored-by: Dan <77840397+Void-ux@users.noreply.github.com>
(I don't know what to put as the title) Co-authored-by: Dan <77840397+Void-ux@users.noreply.github.com>
Co-authored-by: Dan <77840397+Void-ux@users.noreply.github.com>
Co-authored-by: Dan <77840397+Void-ux@users.noreply.github.com>
Co-authored-by: Dan <77840397+Void-ux@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Guide on Sharding and how to do so,
Co-Authored-By @nihaals (#7499)
Checklist