-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add voice channel status events and permission #9604
base: master
Are you sure you want to change the base?
Conversation
I used the constructor instead of an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly okay, however not a big fan on the event at the moment. We're kind of moving away from this style of event but it was too late to commit to it in v2 due to churn.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is fine, but Discord officially says this functionality isn't stable. I don't really know why, considering it's been over a year. That aside, the version strings need to move to the new version target.
It's also not clear what happens regarding the hang status. But I make it merge-ready anyway. |
Summary
This PR adds the events and permission for the voice channel status.
Note: The implementation of the endpoint to set the voice channel status is seperated into a second PR (#9603) because it cannot be merged due to the experiment lock, which this PR already can.
Related PR: discord/discord-api-docs#6398
Checklist