Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add voice channel status events and permission #9604

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Puncher1
Copy link
Contributor

@Puncher1 Puncher1 commented Oct 7, 2023

Summary

This PR adds the events and permission for the voice channel status.

Note: The implementation of the endpoint to set the voice channel status is seperated into a second PR (#9603) because it cannot be merged due to the experiment lock, which this PR already can.

Related PR: discord/discord-api-docs#6398

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Puncher1 Puncher1 changed the title Add voice channel status events and permission [WIP] Add voice channel status events and permission Oct 7, 2023
@Puncher1 Puncher1 changed the title [WIP] Add voice channel status events and permission Add voice channel status events and permission Oct 8, 2023
@Puncher1 Puncher1 marked this pull request as ready for review October 8, 2023 13:56
@Puncher1
Copy link
Contributor Author

Puncher1 commented Oct 8, 2023

I used the constructor instead of an _update method to assign the status because a channel update would overwrite self.status to None since the status is not in the payload of a channel update. In the client however, if you edit the channel the status gets reset which I assume is a UI bug (see this comment: discord/discord-api-docs#6398 (comment))

@Rapptz Rapptz added the pending PR implements an in-progress or explicitly unreleased Discord feature label Nov 19, 2023
Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly okay, however not a big fan on the event at the moment. We're kind of moving away from this style of event but it was too late to commit to it in v2 due to churn.

docs/api.rst Outdated Show resolved Hide resolved
@Rapptz Rapptz removed the pending PR implements an in-progress or explicitly unreleased Discord feature label Dec 26, 2023
@Puncher1 Puncher1 requested a review from Rapptz December 26, 2023 13:48
Copy link
Owner

@Rapptz Rapptz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is fine, but Discord officially says this functionality isn't stable. I don't really know why, considering it's been over a year. That aside, the version strings need to move to the new version target.

@Puncher1
Copy link
Contributor Author

This PR is fine, but Discord officially says this functionality isn't stable. I don't really know why, considering it's been over a year. That aside, the version strings need to move to the new version target.

It's also not clear what happens regarding the hang status. But I make it merge-ready anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants