Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Client.get_user_named #9658

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Soheab
Copy link
Contributor

@Soheab Soheab commented Nov 27, 2023

Summary

This PR adds a method called get_user_named to Client as an equivalent to Guild.get_member_named.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Copy link
Contributor

@lmaotrigine lmaotrigine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs build is failing

discord/client.py Outdated Show resolved Hide resolved
Soheab and others added 2 commits November 29, 2023 09:00
Co-authored-by: lmaotrigine <57328245+lmaotrigine@users.noreply.github.com>
@Rapptz
Copy link
Owner

Rapptz commented Dec 15, 2023

I'm not really sure on the usefulness of this method on whether it's worth adding to the Client class, especially since discriminators aren't really a thing anymore.

@Soheab
Copy link
Contributor Author

Soheab commented Feb 2, 2024

I kept the discriminator impl because of bots and "dead" users I guess. It can be removed all at once anyways.

But not sure where else it could go.. in utils maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants