Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support commands.parameter for hybrid app commands #9894

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Soheab
Copy link
Contributor

@Soheab Soheab commented Jul 28, 2024

Summary

Bit of a misleiding title but what this PR basically does is copy over the displayed_name and description from commands.Parameter if commands.(param)eter is used on a hybrid command param because most people expect this to happen anyways and I think it makes sense.

I don't know if any docs changes are needed here.

Breaking changes

This could be a breaking change for people that don't expect this to happen and may want a different description for the prefix part of the hybrid command or don't want displayed_name to rename it... should there maybe be a toggle for this?

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant