Add support for Interaction Callback Resource #9957
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbstractUmbra
suggested changes
Oct 4, 2024
discord/interactions.py
Outdated
Comment on lines
723
to
726
| self.response_message_id: Optional[int] = ( | ||
| int( | ||
| response_id, | ||
| ) |
There was a problem hiding this comment.
Remove the magic comma here to undo the formatted "ugliness" of this line.
discord/interactions.py
Outdated
Comment on lines
799
to
807
| @overload | ||
| async def defer( | ||
| self, | ||
| *, | ||
| ephemeral: bool = ..., | ||
| thinking: bool = ..., | ||
| with_response: Literal[False] = ..., | ||
| ) -> None: | ||
| ... |
There was a problem hiding this comment.
This overload is wrong, as the = ... implies that you are not providing an argument (thus relying on the default), which in this case would be True, not the implied False here.
Suggested change
| @overload | |
| async def defer( | |
| self, | |
| *, | |
| ephemeral: bool = ..., | |
| thinking: bool = ..., | |
| with_response: Literal[False] = ..., | |
| ) -> None: | |
| ... | |
| @overload | |
| async def defer( | |
| self, | |
| *, | |
| ephemeral: bool = ..., | |
| thinking: bool = ..., | |
| with_response: Literal[False] = False, | |
| ) -> None: | |
| ... |
There was a problem hiding this comment.
I believe the correct method of doing this, would be to edit the overload which contains the "default" implementation (in this case the with_response=True to accept the = ... annotation, or to add a 3rd overload with the default annotation.
discord/interactions.py
Outdated
Comment on lines
929
to
969
| @overload | ||
| async def send_message( | ||
| self, | ||
| content: Optional[Any] = ..., | ||
| *, | ||
| embed: Embed = ..., | ||
| embeds: Sequence[Embed] = ..., | ||
| file: File = ..., | ||
| files: Sequence[File] = ..., | ||
| view: View = ..., | ||
| tts: bool = ..., | ||
| ephemeral: bool = ..., | ||
| allowed_mentions: AllowedMentions = ..., | ||
| suppress_embeds: bool = ..., | ||
| silent: bool = ..., | ||
| delete_after: Optional[float] = ..., | ||
| poll: Poll = ..., | ||
| with_response: Literal[True] = True, | ||
| ) -> InteractionCallback[ClientT]: | ||
| ... | ||
|
|
||
| @overload | ||
| async def send_message( | ||
| self, | ||
| content: Optional[Any] = ..., | ||
| *, | ||
| embed: Embed = ..., | ||
| embeds: Sequence[Embed] = ..., | ||
| file: File = ..., | ||
| files: Sequence[File] = ..., | ||
| view: View = ..., | ||
| tts: bool = ..., | ||
| ephemeral: bool = ..., | ||
| allowed_mentions: AllowedMentions = ..., | ||
| suppress_embeds: bool = ..., | ||
| silent: bool = ..., | ||
| delete_after: Optional[float] = ..., | ||
| poll: Poll = ..., | ||
| with_response: Literal[False] = ..., | ||
| ) -> None: | ||
| ... |
There was a problem hiding this comment.
These overloads have the same issue present in the other mentioned overloads.
discord/interactions.py
Outdated
Comment on lines
1123
to
1153
| @overload | ||
| async def edit_message( | ||
| self, | ||
| *, | ||
| content: Optional[Any] = ..., | ||
| embed: Optional[Embed] = ..., | ||
| embeds: Sequence[Embed] = ..., | ||
| attachments: Sequence[Union[Attachment, File]] = ..., | ||
| view: Optional[View] = ..., | ||
| allowed_mentions: Optional[AllowedMentions] = ..., | ||
| delete_after: Optional[float] = ..., | ||
| suppress_embeds: bool = ..., | ||
| with_response: Literal[True] = True, | ||
| ) -> InteractionCallback[ClientT]: | ||
| ... | ||
|
|
||
| @overload | ||
| async def edit_message( | ||
| self, | ||
| *, | ||
| content: Optional[Any] = ..., | ||
| embed: Optional[Embed] = ..., | ||
| embeds: Sequence[Embed] = ..., | ||
| attachments: Sequence[Union[Attachment, File]] = ..., | ||
| view: Optional[View] = ..., | ||
| allowed_mentions: Optional[AllowedMentions] = ..., | ||
| delete_after: Optional[float] = ..., | ||
| suppress_embeds: bool = ..., | ||
| with_response: Literal[False] = ..., | ||
| ) -> None: | ||
| ... |
There was a problem hiding this comment.
These overload suffer the same issue as the other mentioned overloads.
discord/interactions.py
Outdated
Comment on lines
1302
to
1308
| @overload | ||
| async def send_modal(self, modal: Modal, /, *, with_response: Literal[True] = True) -> InteractionCallback[ClientT]: | ||
| ... | ||
|
|
||
| @overload | ||
| async def send_modal(self, modal: Modal, /, *, with_response: Literal[False] = ...) -> None: | ||
| ... |
There was a problem hiding this comment.
These overloads suffer the same issue as the other mentioned overloads.
owocado
reviewed
Oct 5, 2024
…name response_message_loading to response_message_thinking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds support for the Interaction Callback Resource returned by any
Interaction.responsemethod call by using a new parameter namedwith_response.This also adds the
pollkwarg toInteraction.edit_original_response.Checklist