Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Add new timeline states to try and bring in line with new API #315

Draft
wants to merge 1 commit into
base: openpht-1.9
Choose a base branch
from

Conversation

dalehamel
Copy link
Member

WIP trying to pull in changes from plexinc/plex-media-player@304f4da

The upstream commit seems to indicate that the "stopped" signal to the media server is now invalid, as the server needs to know if it was "finished" or intentionally cancelled.

It's unclear if the "cancelled" signal actually needs to be emitted, but it probably does for the server to behave properly.

To start with, I've just replaced most instances of STOPPED with FINISHED, to try and simplify the patch.

I won't know if this has been effective until I've had a chance to try it out. I'm building a new version of OpenPHT-Embedded based on LibreELEC.tv 9.0.1, which should also bring in proper RPi3b+ support.

I may try and cut a release of the new OpenPHT changes alone, as users of the current stable builds would benefit from a build based on 1.8 more closely, with just the timeline changes. It's unclear what instabilities LibreELEC 9.0.1 may bring in (and which bugs it may fix).

@dalehamel
Copy link
Member Author

The LibreELEC branch this is being built with is here RasPlex/OpenPHT-Embedded#2

@dalehamel
Copy link
Member Author

thanks for sharing @ukdtom !

I still plan to get a new build out for testing within the month, and moving to the new API probably avoids quirks better going forward.

It's great that there will be a workaround in a new server version handled by plex server-side. Thanks @elan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants