Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ATO-2016] Fix App Instantiation Error #1063

Merged
merged 5 commits into from
Jan 15, 2024
Merged

[ATO-2016] Fix App Instantiation Error #1063

merged 5 commits into from
Jan 15, 2024

Conversation

Tawakalt
Copy link
Contributor

@Tawakalt Tawakalt commented Jan 11, 2024 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation in the rasaHQ/rasa
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@Tawakalt Tawakalt requested a review from vcidst January 11, 2024 12:47
@Tawakalt Tawakalt force-pushed the ATO-2016-fix-app-instantiation-error branch from f211245 to afd4ca0 Compare January 11, 2024 14:29
vcidst
vcidst reviewed Jan 15, 2024
View reviewed changes
changelog/1063.bugfix.md Outdated Show resolved Hide resolved
@Tawakalt Tawakalt requested a review from vcidst January 15, 2024 14:30
vcidst
vcidst approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@vcidst vcidst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀

@Tawakalt Tawakalt merged commit 073db29 into main Jan 15, 2024
16 checks passed
@Tawakalt Tawakalt deleted the ATO-2016-fix-app-instantiation-error branch January 15, 2024 14:39
@Tawakalt Tawakalt mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcidst vcidst vcidst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tawakalt @vcidst