Add .dockerignore

[tczekajlo]

Proposed changes:

• Fixes Security Alert #322 Security Alert #327

Status (please check what you already did):

• made PR ready for code review
• added some tests for the functionality
• updated the documentation
• updated the changelog (please check changelog for instructions)
• reformat files using black (please check Readme for instructions)

[tczekajlo]

@m-vdb @wochinge Regarding #322 I assume we don't need to and want to put the docs directory in the rasa-sdk image?

[wochinge]

haha, please not! 😂

[m-vdb]

it also seems that we only need rasa_sdk and entrypoint.sh, am I right? should ignore everything else?

[wochinge]

@m-vdb We need at least the poetry files as well.

I was wondering: Do we need this line in the Dockerfile? In my opinion we

• can only copy the rasa_sdk directory to the next stage
• or (I think even better) is to don't install rasa_sdk in editable mode but actually build the wheel and copy that one over as we do it in the rasa image (see here. See also this poetry issue

I think this approach would be more robust than just doing the .dockerignore (might also be done in combination)

[tczekajlo]

@m-vdb We need at least the poetry files as well.

I was wondering: Do we need this line in the Dockerfile? In my opinion we

• can only copy the rasa_sdk directory to the next stage
• or (I think even better) is to don't install rasa_sdk in editable mode but actually build the wheel and copy that one over as we do it in the rasa image (see here. See also this poetry issue

I think this approach would be more robust than just doing the .dockerignore (might also be done in combination)

My plan was to take care of the rasa-sdk image after https://github.com/RasaHQ/rasa-x/pull/3886 is done.

For now, I propose to add the .dockerignore, and in not far future take care of Docker build as well, wdyt?

[m-vdb]

works for me 👍

[m-vdb]

📟

[wochinge]

works for me as well. Can we also exclude tests then? .github should be excluded by default, right?

[tczekajlo]

works for me as well. Can we also exclude tests then? .github should be excluded by default, right?

It copies everything 😄 I'll add a few more files

[wochinge]

Thanks for adding the missing entries 🚀 Having our .git history in the docker images seems unnecessary 😆

[tczekajlo]

Thanks for adding the missing entries 🚀 Having our .git history in the docker images seems unnecessary 😆

Distributed backup 😄