Multi-platform docker image #12533
Merged
Multi-platform docker image #12533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge 3.6.x into main
Bump version of tensorflow * Fix spacy version, bump the pydantic version because of explosion/spaCy#12659 * Fix ruff version because of new warnings * Fix spacy<3.5 because of tests/nlu/extractors/test_spacy_entity_extractors.py * Downgrade ruamel because of failing test tests/shared/nlu/training_data/formats/test_rasa_yaml.py::test_wrong_format_raises
Remove dependency on tensorflow-addons Copy tests for crf and metrics
* Build both platforms on the same machine
Bump version of tensorflow * Fix spacy version, bump the pydantic version because of explosion/spaCy#12659 * Fix ruff version because of new warnings * Fix spacy<3.5 because of tests/nlu/extractors/test_spacy_entity_extractors.py * Downgrade ruamel because of failing test tests/shared/nlu/training_data/formats/test_rasa_yaml.py::test_wrong_format_raises
Remove dependency on tensorflow-addons Copy tests for crf and metrics
* Build both platforms on the same machine
|
🚀 A preview of the docs have been deployed at the following URL: https://12533--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
twerkmeister
approved these changes
Jun 23, 2023
miraai
reviewed
Jun 23, 2023
| @@ -841,18 +839,15 @@ jobs: | |||
| if: github.event_name != 'pull_request' | |||
|
|
|||
| - name: Set up QEMU | |||
| uses: docker/setup-qemu-action@e81a89b1732b9c48d79cd809d8d81d79c4647a18 | |||
| uses: docker/setup-qemu-action@v2 | |||
There was a problem hiding this comment.
Could you please use SHA instead of a version number? Its part of the security measures, we should stick to SHA on all action versions. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Add multi-platform docker image build in CI
Bump version of the tensorflow (to have wheels for all required platforms)
Removes the tensorflow-addons (deprecated by tensorflow team, no wheel for arm)
Status (please check what you already did):
black(please check Readme for instructions)