Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cli #1715

Merged
merged 21 commits into from
Mar 4, 2019
Merged

Cli #1715

merged 21 commits into from
Mar 4, 2019

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Feb 20, 2019 •
edited
Loading

Proposed changes:

  • fixes https://github.com/RasaHQ/rasa_stack/issues/1
  • renamed rasa_nlu.evaluate to rasa_nlu.test
  • renamed rasa_nlu.test.run_cv_evaluation to
    rasa_nlu.test.cross_validate
  • renamed rasa_nlu.train.do_train() to rasa_nlu.train.train()
  • train command can now also load config from file

Status (please check what you already did):

  • made PR ready for code review
  • [ ] added some tests for the functionality
  • [ ] updated the documentation
  • updated the changelog

@wochinge wochinge marked this pull request as ready for review February 22, 2019 14:27
@codeclimate
Copy link

codeclimate bot commented Feb 24, 2019 •
edited
Loading

Code Climate has analyzed commit c0fe92d and detected 20 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 18
Style 2

View more on Code Climate.

@wochinge wochinge requested a review from tmbo February 28, 2019 09:54
tmbo
tmbo approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, some style comments left to tackle

CHANGELOG.rst Show resolved Hide resolved
rasa_nlu/test.py Show resolved Hide resolved
rasa_nlu/train.py Show resolved Hide resolved
rasa_nlu/training_data/formats/markdown.py Outdated Show resolved Hide resolved
rasa_nlu/training_data/training_data.py Outdated Show resolved Hide resolved
@wochinge wochinge merged commit 1d323ee into master Mar 4, 2019
@wochinge wochinge deleted the cli branch March 4, 2019 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmbo tmbo tmbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wochinge @tmbo