-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cloud Storage Docs #1731
Merged
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1d0bf2c
Make document more explicit about the naming convention and where to …
ShailChoksi e3864c9
Add more information about loading and storing
ShailChoksi f3ae5b3
Fix grammar
ShailChoksi 8ee5446
Merge branch 'master' into update-persist-doc
wochinge 7594c06
Address PR comments
ShailChoksi 5677871
Merge branch 'update-persist-doc' of github.com:careless25/rasa_nlu i…
ShailChoksi 52ff7ff
Merge branch 'master' of https://github.com/RasaHQ/rasa_nlu into upda…
ShailChoksi 75da5b1
Fix grammar/typo
ShailChoksi 53726c2
Addressed PR comments #2
ShailChoksi 0bd9989
Missed a word
ShailChoksi b43b816
Merge branch 'master' into update-persist-doc
wochinge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@careless25 Sure it is not
{PROJECT}{MODEL_NAME}.tar.gz
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, see lines 96-100 in persistor.py
#1731 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 You know the code better than I - awesome job!