Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cloud Storage Docs #1731

Merged
merged 11 commits into from
Mar 1, 2019
Merged

Update Cloud Storage Docs #1731

Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1d0bf2c
Make document more explicit about the naming convention and where to …
ShailChoksi Feb 22, 2019
e3864c9
Add more information about loading and storing
ShailChoksi Feb 22, 2019
f3ae5b3
Fix grammar
ShailChoksi Feb 22, 2019
8ee5446
Merge branch 'master' into update-persist-doc
wochinge Feb 25, 2019
7594c06
Address PR comments
ShailChoksi Feb 26, 2019
5677871
Merge branch 'update-persist-doc' of github.com:careless25/rasa_nlu i…
ShailChoksi Feb 26, 2019
52ff7ff
Merge branch 'master' of https://github.com/RasaHQ/rasa_nlu into upda…
ShailChoksi Feb 26, 2019
75da5b1
Fix grammar/typo
ShailChoksi Feb 26, 2019
53726c2
Addressed PR comments #2
ShailChoksi Feb 26, 2019
0bd9989
Missed a word
ShailChoksi Feb 26, 2019
b43b816
Merge branch 'master' into update-persist-doc
wochinge Feb 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion docs/persist.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,13 @@ Rasa NLU supports using `S3 <https://aws.amazon.com/s3/>`_ and

If there is no container with the name ``AZURE_CONTAINER`` Rasa will create it.

Models are gzipped before saving to cloud.
Models are gzipped before they are saved in the cloud. The gzipped file naming convention
is `{PROJECT}___{MODEL_NAME}.tar.gz` and it is stored in the root folder of the storage service.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@careless25 Sure it is not {PROJECT}{MODEL_NAME}.tar.gz?

Copy link
Contributor Author

@ShailChoksi ShailChoksi Feb 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, see lines 96-100 in persistor.py
#1731 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 You know the code better than I - awesome job!

Currently, you are not able manually to specify the path on cloud storage.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Currently, you are not able manually to specify the path on cloud storage.
Currently, you are not able to manually specify the path on the cloud storage.


If storing trained models, Rasa NLU will gzip the new model and upload to the container. If retrieving/loading models
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If storing trained models, Rasa NLU will gzip the new model and upload to the container. If retrieving/loading models
If storing trained models, Rasa NLU will gzip the new model and upload it to the container. If retrieving/loading models

from the cloud storage, Rasa NLU will download the gzipped model locally an extract the contents to the location
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from the cloud storage, Rasa NLU will download the gzipped model locally an extract the contents to the location
from the cloud storage, Rasa NLU will download the gzipped model locally and extract the contents to the location

specified by the `--path` flag.


.. include:: feedback.inc