Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix entity table #1746

Merged
merged 1 commit into from
Feb 28, 2019
Merged

fix entity table #1746

merged 1 commit into from
Feb 28, 2019

Conversation

Ghostvv
Copy link
Contributor

@Ghostvv Ghostvv commented Feb 28, 2019

Proposed changes:

  • fix entity table in docs

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog

@Ghostvv Ghostvv requested a review from erohmensing February 28, 2019 15:33
@codeclimate
Copy link

codeclimate bot commented Feb 28, 2019

Code Climate has analyzed commit e00e628 and detected 0 issues on this pull request.

View more on Code Climate.

erohmensing
erohmensing approved these changes Feb 28, 2019
View reviewed changes
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just launched it, looks great 👍

@erohmensing erohmensing merged commit e683cf7 into master Feb 28, 2019
@erohmensing erohmensing deleted the docs_fix branch February 28, 2019 16:14
tmbo added a commit that referenced this pull request Mar 21, 2019
@tmbo
Merge pull request #1746 from mark922/patch-1
e138e76 
Adding auth_source param in Mongo DB Tracker Store documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erohmensing erohmensing erohmensing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ghostvv @erohmensing