Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use quick is_key_in_yaml implementation #8208

Merged
merged 3 commits into from
Mar 16, 2021
Merged

use quick is_key_in_yaml implementation #8208

merged 3 commits into from
Mar 16, 2021

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Mar 15, 2021 •
edited
Loading

Proposed changes:

  • use quick is_key_in_yaml implementation

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@wochinge wochinge requested review from a team, federicotdn and alwx and removed request for a team and federicotdn March 15, 2021 16:22
wochinge
wochinge commented Mar 15, 2021
View reviewed changes
rasa/shared/core/training_data/story_reader/yaml_story_reader.py
)

@classmethod
def is_key_in_yaml(cls, file_path: Union[Text, Path], *keys: Text) -> bool:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dobule checked: Not used by Rasa X

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wochinge wochinge self-assigned this Mar 15, 2021
@wochinge wochinge mentioned this pull request Mar 15, 2021
Closed
1 task
@wochinge wochinge force-pushed the fast-nlu-key-in-yaml branch from fb9ef2e to 92f5466 Compare March 16, 2021 08:33
@wochinge wochinge enabled auto-merge March 16, 2021 08:33
@wochinge wochinge merged commit bfa97e1 into main Mar 16, 2021
@wochinge wochinge deleted the fast-nlu-key-in-yaml branch March 16, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alwx alwx alwx approved these changes

Assignees

@wochinge wochinge

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wochinge @alwx